Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 139623003: Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. (Closed)

Created:
6 years, 11 months ago by wibling-chromium
Modified:
6 years, 11 months ago
CC:
blink-reviews, Mads Ager (chromium)
Visibility:
Public.

Description

Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. (https://codereview.chromium.org/139293003/) Reason for revert: This change triggered an issue with out assembly code. Reverting until fixed. Original issue's description: > Trying this patch again. From what we can tell it was a glitch in the MAC WebKit builder since it seemed to recover before the change was reverted. > > Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's. > > We used to use wtf's run_all_tests target to run out blink heap unittests. That causes a problem when we want to initialize our heap since we cannot call Heap::init/shutdown from wtf's RunAllTests since it cannot/should not depend on blink heap. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165205 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165217 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org,alexeif@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -122 lines) Patch
M Source/core/Init.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/heap/HeapTest.cpp View 12 chunks +121 lines, -22 lines 0 comments Download
D Source/heap/RunAllTests.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/heap/blink_heap_tests.gyp View 1 chunk +22 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wibling-chromium
Created Revert of Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's.
6 years, 11 months ago (2014-01-16 13:41:30 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-16 13:41:39 UTC) #2
haraken
LGTM
6 years, 11 months ago (2014-01-16 13:42:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/139623003/1
6 years, 11 months ago (2014-01-16 13:42:47 UTC) #4
Mads Ager (chromium)
LGTM
6 years, 11 months ago (2014-01-16 13:43:01 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 13:43:03 UTC) #6
Message was sent while issue was closed.
Change committed as 165220

Powered by Google App Engine
This is Rietveld 408576698