Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 139623002: Tweaks to get views compiling with mojo (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, ben+corewm_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Tweaks to get views compiling with mojo The one interesting bit is this makes mojo use the aura theme rather than the android theme. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245141

Patch Set 1 #

Patch Set 2 : mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M ui/native_theme/native_theme_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/corewm/transient_window_stacking_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
6 years, 11 months ago (2014-01-15 16:40:44 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-15 19:17:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/139623002/30001
6 years, 11 months ago (2014-01-15 21:47:56 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 05:30:43 UTC) #4
Message was sent while issue was closed.
Change committed as 245141

Powered by Google App Engine
This is Rietveld 408576698