chrome/common/instant_types.h - Issue 1396143002: Emit correct NewTabPage.SuggestionsType metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/instant_types.h

Issue 1396143002: Emit correct NewTabPage.SuggestionsType metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fserb cr feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/instant_types.h

diff --git a/chrome/common/instant_types.h b/chrome/common/instant_types.h

index 617f8f96a76d7917d2ff499113876edeaaed4978..fe66a4eff98c014f2803e7635079ac7b5e6d24ac 100644

--- a/chrome/common/instant_types.h

+++ b/chrome/common/instant_types.h

@@ -142,6 +142,10 @@ struct InstantMostVisitedItem {

// The external URL that should be pinged when this item is suggested/clicked.

GURL impression_url;

GURL click_url;

+ // True if it's a server side suggestion.

+ // Otherwise, it's a client side suggestion.

+ bool is_server_side_suggestion;

};

// An InstantMostVisitedItem along with its assigned restricted ID.