Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/common/instant_types.h

Issue 1396143002: Emit correct NewTabPage.SuggestionsType metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_INSTANT_TYPES_H_ 5 #ifndef CHROME_COMMON_INSTANT_TYPES_H_
6 #define CHROME_COMMON_INSTANT_TYPES_H_ 6 #define CHROME_COMMON_INSTANT_TYPES_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 135
136 // The external URL of the thumbnail associated with this page. 136 // The external URL of the thumbnail associated with this page.
137 GURL thumbnail; 137 GURL thumbnail;
138 138
139 // The external URL of the favicon associated with this page. 139 // The external URL of the favicon associated with this page.
140 GURL favicon; 140 GURL favicon;
141 141
142 // The external URL that should be pinged when this item is suggested/clicked. 142 // The external URL that should be pinged when this item is suggested/clicked.
143 GURL impression_url; 143 GURL impression_url;
144 GURL click_url; 144 GURL click_url;
145
146 // True if it's a server side suggestion.
147 // Otherwise, it's a client side suggestion.
148 bool is_server_side_suggestion;
145 }; 149 };
146 150
147 // An InstantMostVisitedItem along with its assigned restricted ID. 151 // An InstantMostVisitedItem along with its assigned restricted ID.
148 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem> 152 typedef std::pair<InstantRestrictedID, InstantMostVisitedItem>
149 InstantMostVisitedItemIDPair; 153 InstantMostVisitedItemIDPair;
150 154
151 // Embedded search request logging stats params. 155 // Embedded search request logging stats params.
152 extern const char kSearchQueryKey[]; 156 extern const char kSearchQueryKey[];
153 extern const char kOriginalQueryKey[]; 157 extern const char kOriginalQueryKey[];
154 extern const char kRLZParameterKey[]; 158 extern const char kRLZParameterKey[];
(...skipping 23 matching lines...) Expand all
178 182
179 // The optional assisted query stats, aka AQS, used for logging purposes. 183 // The optional assisted query stats, aka AQS, used for logging purposes.
180 // This string contains impressions of all autocomplete matches shown 184 // This string contains impressions of all autocomplete matches shown
181 // at the query submission time. For privacy reasons, we require the 185 // at the query submission time. For privacy reasons, we require the
182 // search provider to support HTTPS protocol in order to receive the AQS 186 // search provider to support HTTPS protocol in order to receive the AQS
183 // param. 187 // param.
184 // For more details, see http://goto.google.com/binary-clients-logging. 188 // For more details, see http://goto.google.com/binary-clients-logging.
185 base::string16 assisted_query_stats; 189 base::string16 assisted_query_stats;
186 }; 190 };
187 #endif // CHROME_COMMON_INSTANT_TYPES_H_ 191 #endif // CHROME_COMMON_INSTANT_TYPES_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698