Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: src/ic/mips/ic-mips.cc

Issue 1396133002: MIPS: r6 compact branch optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased, gcc build fixed, ra alignment failure fixed. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mips/assembler-mips.h » ('j') | src/mips/assembler-mips.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/mips/ic-mips.cc
diff --git a/src/ic/mips/ic-mips.cc b/src/ic/mips/ic-mips.cc
index beff9a90a67b61684c4a0c42ec7b055a9abb2625..7b4289e7f37aeb10b3f082a8dfb16ec0a06618af 100644
--- a/src/ic/mips/ic-mips.cc
+++ b/src/ic/mips/ic-mips.cc
@@ -902,12 +902,7 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) {
patcher.masm()->andi(at, reg, 0);
}
DCHECK(Assembler::IsBranch(branch_instr));
- if (Assembler::IsBeq(branch_instr)) {
- patcher.ChangeBranchCondition(ne);
- } else {
- DCHECK(Assembler::IsBne(branch_instr));
- patcher.ChangeBranchCondition(eq);
- }
+ patcher.ChangeBranchCondition();
paul.l... 2015/10/15 01:51:24 I kind of like the old way, where you check if (eq
balazs.kilvady 2015/10/30 21:11:14 Done.
}
} // namespace internal
} // namespace v8
« no previous file with comments | « no previous file | src/mips/assembler-mips.h » ('j') | src/mips/assembler-mips.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698