Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1396113003: Fix codec memory leaks in nanobench (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix codec memory leaks in nanobench SubsetTranslateBench.cpp: Unref the color table, so it gets deleted. SkBitmapRegionDecoderInterface.cpp: Delete the stream if it is not used. BUG=skia:3418 Committed: https://skia.googlesource.com/skia/+/e361781bf7ce8acd4af00c426b34596804d45d77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M bench/subset/SubsetTranslateBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/SkBitmapRegionDecoderInterface.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
scroggo
5 years, 2 months ago (2015-10-09 19:02:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396113003/1
5 years, 2 months ago (2015-10-09 19:03:01 UTC) #4
msarett
LGTM
5 years, 2 months ago (2015-10-09 19:08:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-09 19:09:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396113003/1
5 years, 2 months ago (2015-10-09 19:15:14 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 19:16:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e361781bf7ce8acd4af00c426b34596804d45d77

Powered by Google App Engine
This is Rietveld 408576698