Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tools/nanobench_flags.py

Issue 1396113002: Renable image benchmarking (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add fixmes in response to comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 11 matching lines...) Expand all
22 22
23 def lineno(): 23 def lineno():
24 caller = inspect.stack()[1] # Up one level to our caller. 24 caller = inspect.stack()[1] # Up one level to our caller.
25 return inspect.getframeinfo(caller[0]).lineno 25 return inspect.getframeinfo(caller[0]).lineno
26 26
27 27
28 cov_start = lineno()+1 # We care about coverage starting just past this def. 28 cov_start = lineno()+1 # We care about coverage starting just past this def.
29 def get_args(bot): 29 def get_args(bot):
30 args = [] 30 args = []
31 31
32 # Temporarily disable image benchmarking. 32 if 'GPU' in bot:
33 args.append('--images') 33 args.append('--images')
34 34
35 if 'Appurify' not in bot: 35 if 'Appurify' not in bot:
36 args.extend(['--scales', '1.0', '1.1']) 36 args.extend(['--scales', '1.0', '1.1'])
37 37
38 if 'iOS' in bot: 38 if 'iOS' in bot:
39 args.extend(['--skps', 'ignore_skps']) 39 args.extend(['--skps', 'ignore_skps'])
40 40
41 if 'Appurify' not in bot: 41 if 'Appurify' not in bot:
42 config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui'] 42 config = ['565', '8888', 'gpu', 'nonrendering', 'angle', 'hwui']
43 # The S4 crashes and the NP produces a long error stream when we run with 43 # The S4 crashes and the NP produces a long error stream when we run with
(...skipping 29 matching lines...) Expand all
73 if 'GalaxyS4' in bot: 73 if 'GalaxyS4' in bot:
74 match.append('~GLInstancedArraysBench') # skia:4371 74 match.append('~GLInstancedArraysBench') # skia:4371
75 75
76 if 'iOS' in bot: 76 if 'iOS' in bot:
77 match.append('~blurroundrect') 77 match.append('~blurroundrect')
78 match.append('~patch_grid') # skia:2847 78 match.append('~patch_grid') # skia:2847
79 match.append('~desk_carsvg') 79 match.append('~desk_carsvg')
80 match.append('~keymobi') 80 match.append('~keymobi')
81 match.append('~path_hairline') 81 match.append('~path_hairline')
82 82
83 # the 32-bit GCE bots run out of memory in DM when running these large images
84 # so defensively disable them in nanobench, too.
85 # FIXME (scroggo): This may have just been due to SkImageDecoder's
86 # buildTileIndex leaking memory (skbug.com/4360). That is disabled by
87 # default for nanobench, so we may not need this.
88 # FIXME (scroggo): Share image blacklists between dm and nanobench?
89 if 'x86' in bot and not 'x86-64' in bot:
90 match.append('~interlaced1.png')
91 match.append('~interlaced2.png')
92 match.append('~interlaced3.png')
93
83 if match: 94 if match:
84 args.append('--match') 95 args.append('--match')
85 args.extend(match) 96 args.extend(match)
86 97
87 return args 98 return args
88 cov_end = lineno() # Don't care about code coverage past here. 99 cov_end = lineno() # Don't care about code coverage past here.
89 100
90 101
91 def self_test(): 102 def self_test():
92 import coverage # This way the bots don't need coverage.py to be installed. 103 import coverage # This way the bots don't need coverage.py to be installed.
(...skipping 29 matching lines...) Expand all
122 if len(sys.argv) == 2 and sys.argv[1] == 'test': 133 if len(sys.argv) == 2 and sys.argv[1] == 'test':
123 self_test() 134 self_test()
124 sys.exit(0) 135 sys.exit(0)
125 136
126 if len(sys.argv) != 3: 137 if len(sys.argv) != 3:
127 print usage 138 print usage
128 sys.exit(1) 139 sys.exit(1)
129 140
130 with open(sys.argv[1], 'w') as out: 141 with open(sys.argv[1], 'w') as out:
131 json.dump(get_args(sys.argv[2]), out) 142 json.dump(get_args(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698