Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: pkg/analysis_server/lib/src/search/type_hierarchy.dart

Issue 1396053003: Stop looking for overrides once the pivot element reached. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/search/type_hierarchy_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/search/type_hierarchy.dart
diff --git a/pkg/analysis_server/lib/src/search/type_hierarchy.dart b/pkg/analysis_server/lib/src/search/type_hierarchy.dart
index a4b5837ec18685f3184da445a93187e5e66dfbf2..695693cf7d9304693b1b7bfb92542469c89cac7e 100644
--- a/pkg/analysis_server/lib/src/search/type_hierarchy.dart
+++ b/pkg/analysis_server/lib/src/search/type_hierarchy.dart
@@ -131,9 +131,8 @@ class TypeHierarchyComputer {
ExecutableElement memberElement = _findMemberElement(classElement);
item = new TypeHierarchyItem(convertElement(classElement),
displayName: displayName,
- memberElement: memberElement != null
- ? convertElement(memberElement)
- : null);
+ memberElement:
+ memberElement != null ? convertElement(memberElement) : null);
_elementItemMap[classElement] = item;
itemId = _items.length;
_items.add(item);
@@ -193,6 +192,9 @@ class TypeHierarchyComputer {
result = mixinElement.lookUpSetter(_pivotName, _pivotLibrary);
}
}
+ if (result == _pivotElement) {
+ return null;
+ }
if (result != null) {
return result;
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/search/type_hierarchy_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698