Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 139603002: <webview>: Speculative crash fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adddressed comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guestview/guestview.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 84675b572325b4dddf1b045249f7a39399c653e1..92a7c8462bda4d7542d6daa7910e13e02ff1e450 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -524,10 +524,6 @@ class CONTENT_EXPORT BrowserPluginGuest
// Forwards all messages from the |pending_messages_| queue to the embedder.
void SendQueuedMessages();
- // Weak pointer used to ask GeolocationPermissionContext about geolocation
- // permission.
- base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
-
// Static factory instance (always NULL for non-test).
static BrowserPluginHostFactory* factory_;
@@ -600,6 +596,10 @@ class CONTENT_EXPORT BrowserPluginGuest
// embedder.
scoped_ptr<base::DictionaryValue> extra_attach_params_;
+ // Weak pointer used to ask GeolocationPermissionContext about geolocation
+ // permission.
+ base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
};
« no previous file with comments | « chrome/browser/guestview/guestview.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698