chrome/browser/guestview/guestview.cc - Issue 139603002: <webview>: Speculative crash fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guestview/guestview.cc

Issue 139603002: <webview>: Speculative crash fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guestview/guestview.cc

diff --git a/chrome/browser/guestview/guestview.cc b/chrome/browser/guestview/guestview.cc

index ecf5991efbbe151ccfddeefc92467ba83e4672e9..0e3e40f0ab3844120bad178e450b63d01e436ff1 100644

--- a/chrome/browser/guestview/guestview.cc

+++ b/chrome/browser/guestview/guestview.cc

@@ -46,7 +46,8 @@ scoped_ptr<base::DictionaryValue> GuestView::Event::GetArguments() {

GuestView::GuestView(WebContents* guest_web_contents,

const std::string& extension_id)

- : guest_web_contents_(guest_web_contents),

+ : weak_ptr_factory_(this),

+ guest_web_contents_(guest_web_contents),

embedder_web_contents_(NULL),

extension_id_(extension_id),

embedder_render_process_id_(0),

@@ -157,7 +158,7 @@ void GuestView::Attach(content::WebContents* embedder_web_contents,

base::MessageLoop::current()->PostTask(

FROM_HERE,

base::Bind(&GuestView::SendQueuedEvents,

- base::Unretained(this)));

+ weak_ptr_factory_.GetWeakPtr()));

}

GuestView::Type GuestView::GetViewType() const {