Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1396023002: Rename instr_action.gypi to emma_instr_action.gypi (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename instr_action.gypi to emma_instr_action.gypi There are many types of instrumentation in Chromium: Emma code coverage, order profiling etc. This CL renames instr_action.gypi to emma_instr_action.gypi to make it clearer what type of instrumentation the file deals with. BUG=None Committed: https://crrev.com/58bb840b294fccad8ed5e4860243ce72ae4ba08c Cr-Commit-Position: refs/heads/master@{#353863}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -63 lines) Patch
A + build/android/emma_instr_action.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
D build/android/instr_action.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
M build/java.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pkotwicz
Andrew PTAL
5 years, 2 months ago (2015-10-09 17:35:30 UTC) #3
agrieve
On 2015/10/09 17:35:30, pkotwicz wrote: > Andrew PTAL lgtm
5 years, 2 months ago (2015-10-09 17:44:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396023002/60001
5 years, 2 months ago (2015-10-13 20:16:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-13 21:46:38 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 21:47:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58bb840b294fccad8ed5e4860243ce72ae4ba08c
Cr-Commit-Position: refs/heads/master@{#353863}

Powered by Google App Engine
This is Rietveld 408576698