Issue 139583002: [try 2] skpmaker: make the SKP more graphically interesting (add a border)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139583002: [try 2] skpmaker: make the SKP more graphically interesting (add a border) (Closed)

Created:
6 years, 11 months ago by epoger

Modified:
6 years, 11 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

[try 2] skpmaker: make the SKP more graphically interesting (add a border) relanding https://codereview.chromium.org/137993008/ BUG=skia:1942 NOTRY=True TBR=rmistry Committed: http://code.google.com/p/skia/source/detail?r=13088

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	tools/skpmaker.cpp	View		2 chunks	+8 lines, -3 lines	0 comments	Download
	M	tools/tests/render_pictures_test.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

epoger

Looks like the error on the buildbots was a transient. Sending the original CL to ...

6 years, 11 months ago (2014-01-15 16:28:46 UTC) #1

epoger

The original CL passed the same trybots that failed last time I committed it. I'm ...

6 years, 11 months ago (2014-01-15 16:33:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/139583002/1

6 years, 11 months ago (2014-01-15 16:33:25 UTC) #3

LGTM