Add a short delay before showing the first run bubble.

chrome/browser/first_run/first_run.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include <algorithm>
 
+#include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/lazy_instance.h"
+#include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
 #include "base/stringprintf.h"
+#include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
 #include "chrome/browser/first_run/first_run_dialog.h"
 #include "chrome/browser/first_run/first_run_import_observer.h"
 #include "chrome/browser/first_run/first_run_internal.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/importer/external_process_importer_host.h"
@@ skipping 27 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "googleurl/src/gurl.h"
 
 using content::UserMetricsAction;
 
 namespace {
 
+// How long to delay showing the first run bubble (in milliseconds).
+const int kFirstRunBubbleDelayMs = 200;
+
 // Flags for functions of similar name.
 bool should_show_welcome_page_ = false;
 bool should_do_autofill_personal_data_manager_first_run_ = false;
 
 // Flags indicating whether a first-run profile auto import was performed, and
 // whether the importer process exited successfully.
 bool did_perform_profile_import = false;
 bool profile_import_exited_successfully = false;
 
 // Helper class that performs delayed first-run tasks that need more of the
@@ skipping 493 matching lines @@
   // Suppress the first run bubble if a global error bubble is pending.
   GlobalErrorService* global_error_service =
       GlobalErrorServiceFactory::GetForProfile(browser->profile());
   if (global_error_service->GetFirstGlobalErrorWithBubbleView() != NULL)
     return;
 
   // Reset the preference and notifications to avoid showing the bubble again.
   prefs->SetInteger(prefs::kShowFirstRunBubbleOption,
                     FIRST_RUN_BUBBLE_DONT_SHOW);
 
-  // Show the bubble now and destroy this bubble launcher.
-  browser->ShowFirstRunBubble();
+  // Show the bubble soon.
+  base::MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(
+          &Browser::ShowFirstRunBubble,
+          base::Unretained(browser)),

[grt (UTC plus 2), 2013/04/10 15:14:06]

this will be crashy since the browser window could go away before your task
runs. to protect against this you'll need to ensure that your callback is
neutered if the browser vanishes. i suspect you'll need a combination of a
BrowserListObserver and weak pointers. for example:

base::MessageLoop::current()->PostDelayedTask(
    FROM_HERE,
    base::Bind(&FirstRunBubbleTask::ShowFirstRunBubble,
               (new FirstRunBubbleTask(browser))->AsWeakPtr()));

class FirstRunBubbleTask : public BrowserListObserver, public
SupportsWeakPtr<FirstRunBubbleTask> {
 public:
  explicit FirstRunBubbleTask(Browser* browser) : browser_(browser) {
    BrowserList::AddObserver(this);
  }
  virtual ~FirstRunBubbleTask() {
    BrowserList::RemoveObserver(this);
  }    
  void ShowFirstRunBubble() {
    browser_->ShowFirstRunBubble();
  }
 protected:
  virtual void OnBrowserRemoved(Browser* browser) OVERRIDE {
    if (browser == browser_)
      delete this;
  }
 private:
  Browser* browser_;
};

please excuse any silliness there; it's off the top of my head. i think it'll do
the right thing. you may be able to find similar/better patterns in the codebase
with a little searching.

[macourteau, 2013/04/10 20:54:26]

Thanks for the suggestion - helped a lot. I've merged it into the
FirstRunBubbleLauncher instead of creating another class for this.

+      base::TimeDelta::FromMilliseconds(kFirstRunBubbleDelayMs));
+
+  // Destroy this bubble launcher.
   delete this;
 }
 
 void SetMasterPrefsPathForTesting(const base::FilePath& master_prefs) {
   internal::master_prefs_path_for_testing.Get() = master_prefs;
 }
 
 ProcessMasterPreferencesResult ProcessMasterPreferences(
     const base::FilePath& user_data_dir,
     MasterPrefs* out_prefs) {
@@ skipping 158 matching lines @@
   internal::DoPostImportPlatformSpecificTasks();
 }
 
 bool DidPerformProfileImport(bool* exited_successfully) {
   if (exited_successfully)
     *exited_successfully = profile_import_exited_successfully;
   return did_perform_profile_import;
 }
 
 }  // namespace first_run