skia: Add ANGLE support on Mac

skia: Add ANGLE support on Mac

I want to be able to compare ANGLE vs CommandBuffer for
dm and nanobench on Mac, so enabling ANGLE on mac.

Committed: https://skia.googlesource.com/skia/+/9a7404188e4fe435a97b17685ec9959f1e5c220f

[hendrikw, 2015-10-09 18:38:22]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-10-09 18:38:36]

PTAL, thanks!

[hendrikw, 2015-10-23 16:08:45]

On 2015/10/09 18:38:36, hendrikw wrote:
> PTAL, thanks!

ping, this change isn't very important, but it will be useful for angle's manual
testing in the future.

[bsalomon, 2015-10-23 16:18:20]

Sorry I didn't review this earlier!

https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi#...
gyp/common_conditions.gypi:468: 'YY_NO_INPUT', # ANGLE for mac hits
-Wunneeded-internal-declaration if this isn't set.
Is it possible to specify this only for the angle target?

[hendrikw, 2015-10-28 00:25:35]

On 2015/10/23 16:18:20, bsalomon wrote:
> Sorry I didn't review this earlier!
> 
> https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi#...
> gyp/common_conditions.gypi:468: 'YY_NO_INPUT', # ANGLE for mac hits
> -Wunneeded-internal-declaration if this isn't set.
> Is it possible to specify this only for the angle target?

I've made it conditional on it being skia_angle, I tried moving it to angle.gyp,
and angle itself, but gyp files... they suck... a lot.  I can't wait for GN to
destroy them (btw, is a GN planned for skia?)

PTAL, thanks!

[bsalomon, 2015-10-28 12:58:20]

On 2015/10/28 00:25:35, hendrikw wrote:
> On 2015/10/23 16:18:20, bsalomon wrote:
> > Sorry I didn't review this earlier!
> > 
> > https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi
> > File gyp/common_conditions.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1395783003/diff/1/gyp/common_conditions.gypi#...
> > gyp/common_conditions.gypi:468: 'YY_NO_INPUT', # ANGLE for mac hits
> > -Wunneeded-internal-declaration if this isn't set.
> > Is it possible to specify this only for the angle target?
> 
> I've made it conditional on it being skia_angle, I tried moving it to
angle.gyp,
> and angle itself, but gyp files... they suck... a lot.  I can't wait for GN to
> destroy them (btw, is a GN planned for skia?)
> 
> PTAL, thanks!

lgtm.  We're not sure yet exactly where were going yet. Most Skia devs make a
lot of use of IDEs so without xproj/sln support we probably won't move to gn for
standalone Skia. We have a cmake build for clients, might wind up using that for
devs as well.

[hendrikw, 2015-10-28 15:31:02]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2015-10-28 15:31:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395783003/20001

[commit-bot: I haz the power, 2015-10-28 15:42:33]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9a7404188e4fe435a97b17685ec9959f1e5c220f