Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: pdfium.gyp

Issue 1395733006: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Always build with V8 under GN. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/javascript/JS_Stub.cpp ('k') | samples/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index a728cea89e18ef20152b186cc064d960ed3b5813..a9130676d889ea90527f0ce29476c658e8458ae4 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -1,6 +1,7 @@
{
'variables': {
'pdf_use_skia%': 0,
+ 'pdf_enable_v8%': 1,
'conditions': [
['OS=="linux"', {
'bundle_freetype%': 0,
@@ -23,6 +24,9 @@
['pdf_use_skia==1', {
'defines': ['_SKIA_SUPPORT_'],
}],
+ ['pdf_enable_v8==1', {
+ 'defines': ['PDF_ENABLE_V8'],
+ }],
['OS=="linux"', {
'conditions': [
['target_arch=="x64"', {
@@ -55,8 +59,6 @@
'fxcrt',
'fxedit',
'fxge',
- 'javascript',
- 'jsapi',
'pdfwindow',
],
'ldflags': [ '-L<(PRODUCT_DIR)',],
@@ -105,6 +107,11 @@
'public/fpdfview.h',
],
'conditions': [
+ ['pdf_enable_v8==1', {
+ 'dependencies': [ 'javascript' ],
+ }, {
+ 'dependencies': [ 'javascript_stub' ],
+ }],
['OS!="win"', {
'sources!': [
'fpdfsdk/src/fpdfsdkdll.rc',
@@ -617,6 +624,7 @@
'<(DEPTH)/v8/include',
],
'dependencies': [
+ 'jsapi',
'<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
],
'export_dependent_settings': [
@@ -670,6 +678,15 @@
],
},
{
+ 'target_name': 'javascript_stub',
Tom Sepez 2015/10/08 19:26:50 actually, I think I'll just use the javascript tar
+ 'type': 'static_library',
+ 'ldflags': [ '-L<(PRODUCT_DIR)',],
+ 'sources': [
+ 'fpdfsdk/include/javascipt/IJavascript.h',
+ 'fpdfsdk/src/javascript/JS_Stub.cpp',
+ ],
+ },
+ {
'target_name': 'jsapi',
'type': 'static_library',
'dependencies': [
@@ -747,14 +764,10 @@
'dependencies': [
'<(DEPTH)/testing/gmock.gyp:gmock',
'<(DEPTH)/testing/gtest.gyp:gtest',
- '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
- '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
'pdfium',
],
'include_dirs': [
'<(DEPTH)',
- '<(DEPTH)/v8',
- '<(DEPTH)/v8/include',
],
'sources': [
'core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp',
@@ -766,7 +779,6 @@
'fpdfsdk/src/fpdfview_c_api_test.c',
'fpdfsdk/src/fpdfview_c_api_test.h',
'fpdfsdk/src/fpdfview_embeddertest.cpp',
- 'fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp',
'testing/embedder_test.cpp',
'testing/embedder_test.h',
'testing/embedder_test_mock_delegate.h',
@@ -774,6 +786,21 @@
'testing/fx_string_testhelpers.cpp',
'testing/fx_string_testhelpers.h',
],
+ 'conditions': [
+ ['pdf_enable_v8==1', {
+ 'include_dirs': [
+ '<(DEPTH)/v8',
+ '<(DEPTH)/v8/include',
+ ],
+ 'dependencies': [
+ '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
+ '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
+ ],
+ 'sources': [
+ 'fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp',
+ ],
+ }],
+ ],
},
],
}
« no previous file with comments | « fpdfsdk/src/javascript/JS_Stub.cpp ('k') | samples/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698