fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1395733006: Allow compiling PDFium without V8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1395733006: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Always build with V8 under GN. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index fcf6ee879511d49aa2bad38e28cc8369559392e9..cdb4e3d77dd35d54ef72ed572d2bf49c5e3047a3 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -27,8 +27,12 @@

#include "report.h"

#include "util.h"

-/* ------------------------------ CJS_Runtime ------------------------------ */

+// static

+void IJS_Runtime::Initialize(unsigned int slot, void* isolate) {

+ FXJS_Initialize(slot, reinterpret_cast<v8::Isolate*>(isolate));

+// static

IJS_Runtime* IJS_Runtime::Create(CPDFDoc_Environment* pEnv) {

return new CJS_Runtime(pEnv);

}