BUILD.gn - Issue 1395733006: Allow compiling PDFium without V8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1395733006: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Always build with V8 under GN. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index f048f9db3c45128c5e1e8b3fb9355afbda201150..4069e4a56392122c2012a212c3a275c5a13ef5fa 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -17,6 +17,7 @@ config("pdfium_config") {

include_dirs = [ "third_party/freetype/include" ]

defines = [

"OPJ_STATIC",

+ "PDF_ENABLE_V8",

"V8_DEPRECATION_WARNINGS",

"_CRT_SECURE_NO_WARNINGS",

]

« no previous file with comments | « no previous file | build/all.gyp » ('j') | pdfium.gyp » ('J')