Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: samples/samples.gyp

Issue 1395733006: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: PDFium Authors Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/samples.gyp
diff --git a/samples/samples.gyp b/samples/samples.gyp
index 4b6c16bf2e4827ab7c4a2e578ffb58fe460a11b9..496a274da73c93d6da5f3927270ea333a603b70e 100644
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -3,6 +3,9 @@
# found in the LICENSE file.
{
+ 'variables': {
+ 'pdf_enable_v8%': 1,
+ },
'target_defaults': {
'defines' : [
'PNG_PREFIX',
@@ -11,8 +14,17 @@
],
'include_dirs': [
'<(DEPTH)',
- '<(DEPTH)/v8',
- '<(DEPTH)/v8/include',
+ ],
+ 'conditions': [
+ ['pdf_enable_v8==1', {
+ 'defines': [
+ 'PDF_ENABLE_V8',
+ ],
+ 'include_dirs': [
+ '<(DEPTH)/v8',
+ '<(DEPTH)/v8/include',
+ ],
+ }],
],
},
'targets': [
@@ -26,7 +38,6 @@
# always link this binary against the bundled one for consistency
# of results across platforms.
'../third_party/third_party.gyp:fx_freetype',
- '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
],
'sources': [
'pdfium_test.cc',
@@ -37,6 +48,13 @@
'-lfreetype',
],
},
+ 'conditions': [
+ ['pdf_enable_v8==1', {
+ 'dependencies': [
+ '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform',
+ ],
+ }],
+ ],
},
{
'target_name': 'pdfium_diff',
« no previous file with comments | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698