Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ui/base/events/key_identifier_conversion_unittest.cc

Issue 13957005: Move KeyIdentifier->KeyEvent conversion to src/ui/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gyp fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events/key_identifier_conversion.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/events/key_identifier_conversion_unittest.cc
diff --git a/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc b/ui/base/events/key_identifier_conversion_unittest.cc
similarity index 71%
rename from chrome/browser/extensions/key_identifier_conversion_views_unittest.cc
rename to ui/base/events/key_identifier_conversion_unittest.cc
index 006d96e5616554bc1c5ae656a76312b80ac41399..cd862134b0779f27851a25a010c0fcf83fe86da4 100644
--- a/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc
+++ b/ui/base/events/key_identifier_conversion_unittest.cc
@@ -2,36 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/extensions/key_identifier_conversion_views.h"
+#include "ui/base/events/key_identifier_conversion.h"
#include "base/basictypes.h"
#include "base/logging.h"
-#include "base/message_loop.h"
-#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/events/event.h"
#include "ui/base/keycodes/keyboard_codes.h"
-using content::BrowserThread;
+namespace ui {
-namespace {
-
-class KeyEventFromKeyIdentifierTest : public testing::Test {
- protected:
- KeyEventFromKeyIdentifierTest()
- : ui_thread_(BrowserThread::UI, &message_loop_) {}
-
- MessageLoopForUI message_loop_;
- content::TestBrowserThread ui_thread_;
-};
-
-TEST_F(KeyEventFromKeyIdentifierTest, MatchOnIdentifier) {
+TEST(KeyEventFromKeyIdentifierTest, MatchOnIdentifier) {
EXPECT_EQ(ui::VKEY_APPS, KeyEventFromKeyIdentifier("Apps").key_code());
EXPECT_EQ(ui::VKEY_UNKNOWN,
KeyEventFromKeyIdentifier("Nonsense").key_code());
}
-TEST_F(KeyEventFromKeyIdentifierTest, MatchOnCharacter) {
+TEST(KeyEventFromKeyIdentifierTest, MatchOnCharacter) {
EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("a").key_code());
EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("A").key_code());
EXPECT_EQ(ui::VKEY_OEM_PERIOD, KeyEventFromKeyIdentifier(">").key_code());
@@ -42,7 +29,7 @@ TEST_F(KeyEventFromKeyIdentifierTest, MatchOnCharacter) {
KeyEventFromKeyIdentifier(non_printing_char).key_code());
}
-TEST_F(KeyEventFromKeyIdentifierTest, MatchOnUnicodeCodepoint) {
+TEST(KeyEventFromKeyIdentifierTest, MatchOnUnicodeCodepoint) {
EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0041").key_code());
EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0061").key_code());
EXPECT_EQ(ui::VKEY_DELETE, KeyEventFromKeyIdentifier("U+007F").key_code());
@@ -54,11 +41,11 @@ TEST_F(KeyEventFromKeyIdentifierTest, MatchOnUnicodeCodepoint) {
EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("U+0001").key_code());
}
-TEST_F(KeyEventFromKeyIdentifierTest, DoesNotMatchEmptyString) {
+TEST(KeyEventFromKeyIdentifierTest, DoesNotMatchEmptyString) {
EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("").key_code());
}
-TEST_F(KeyEventFromKeyIdentifierTest, ShiftModifiersAreSet) {
+TEST(KeyEventFromKeyIdentifierTest, ShiftModifiersAreSet) {
EXPECT_EQ(0, KeyEventFromKeyIdentifier("1").flags());
const char* keys_with_shift[] = {
@@ -73,4 +60,4 @@ TEST_F(KeyEventFromKeyIdentifierTest, ShiftModifiersAreSet) {
}
}
-} // namespace
+} // namespace ui
« no previous file with comments | « ui/base/events/key_identifier_conversion.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698