Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: ui/base/events/key_identifier_conversion.h

Issue 13957005: Move KeyIdentifier->KeyEvent conversion to src/ui/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gyp fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events/event.h ('k') | ui/base/events/key_identifier_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/events/key_identifier_conversion.h
diff --git a/chrome/browser/extensions/key_identifier_conversion_views.h b/ui/base/events/key_identifier_conversion.h
similarity index 55%
rename from chrome/browser/extensions/key_identifier_conversion_views.h
rename to ui/base/events/key_identifier_conversion.h
index d13f47a5d89bfeb9d3dcbc750e150e6a77df0e19..9e708ad2bd43aa8d7735cda63f76b68e303941ac 100644
--- a/chrome/browser/extensions/key_identifier_conversion_views.h
+++ b/ui/base/events/key_identifier_conversion.h
@@ -2,21 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
-#define CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
-
-#include "ui/base/keycodes/keyboard_codes.h"
+#ifndef UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_
+#define UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_
#include <string>
+#include "ui/base/ui_export.h"
+
namespace ui {
+
class KeyEvent;
-}
// Convert a KeyIdentifer (see Section 6.3.3 here:
// http://www.w3.org/TR/DOM-Level-3-Events/#keyset-keyidentifiers)
// to a ui::KeyEvent.
-const ui::KeyEvent& KeyEventFromKeyIdentifier(
+// This should only be called from the UI thread.
+UI_EXPORT const ui::KeyEvent& KeyEventFromKeyIdentifier(
const std::string& key_identifier);
-#endif // CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
+} // namespace ui
+
+#endif // UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_
« no previous file with comments | « ui/base/events/event.h ('k') | ui/base/events/key_identifier_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698