Move KeyIdentifier->KeyEvent conversion to src/ui/.

ui/base/events/key_identifier_conversion.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
-#define CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
-
-#include "ui/base/keycodes/keyboard_codes.h"
+#ifndef UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_
+#define UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_
 
 #include <string>
 
+#include "ui/base/keycodes/keyboard_codes.h"

[sadrul, 2013/04/15 02:05:12]

You probably don't need this include here?

[bryeung, 2013/04/15 15:34:13]

Good catch.  Done.

+#include "ui/base/ui_export.h"
+
 namespace ui {
+
 class KeyEvent;
-}
 
 // Convert a KeyIdentifer (see Section 6.3.3 here:
 // http://www.w3.org/TR/DOM-Level-3-Events/#keyset-keyidentifiers)
 // to a ui::KeyEvent.
-const ui::KeyEvent& KeyEventFromKeyIdentifier(
+UI_EXPORT const ui::KeyEvent& KeyEventFromKeyIdentifier(

[sadrul, 2013/04/15 02:05:12]

I wonder if there could be a KeyEvent constructor instead that takes in the
string identifier.

[bryeung, 2013/04/15 15:34:13]

It could, but I didn't for two reasons:
- this is a pretty big, hairy chunk of code that I'd prefer to keep separate
from the core events.* files.
- it doesn't create a "real" KeyEvent, just a "prototype" key event that then
requires the other setup.

That said, if we think this belongs in the core KeyEvent API (via the
constructor), I could easily work around both of those issues.  Would you prefer
I moved it there?

[sadrul, 2013/04/15 16:53:28]

Thanks for explaining. I now agree with you that having this separate sounds
better.

     const std::string& key_identifier);
 
-#endif  // CHROME_BROWSER_EXTENSIONS_KEY_IDENTIFIER_CONVERSION_VIEWS_H_
+}  // namespace ui
+
+#endif  // UI_BASE_EVENTS_KEY_IDENTIFIER_CONVERSION_H_