crashpad_database_util: Don’t create a database unless explicitly asked

client/crash_report_database.h

Index: client/crash_report_database.h
diff --git a/client/crash_report_database.h b/client/crash_report_database.h
index baf95adcd335fce906b4c5b0f312210c561a11ed..4642c322becd1a519999ab6bab1ada662dc6be5d 100644
--- a/client/crash_report_database.h
+++ b/client/crash_report_database.h
@@ -168,10 +168,17 @@ class CrashReportDatabase {
   //! \brief Initializes a database of crash reports.
   //!
   //! \param[in] path A path to the database to be created or opened.
+  //! \param[in] create If `true`, a database that does not yet exist will be
+  //!     created if possible. If `false`, the database must already exist. Note
+  //!     that for databases implemented as directory structures, existence
+  //!     refers solely to the outermost directory, and that if the outermost
+  //!     directory exists, any inner structure will be created even if \a
+  //!     create is `false`.
   //!
   //! \return A database object on success, `nullptr` on failure with an error
   //!     logged.
-  static scoped_ptr<CrashReportDatabase> Initialize(const base::FilePath& path);
+  static scoped_ptr<CrashReportDatabase> Initialize(const base::FilePath& path,
+                                                    bool create);

[Mark Mentovai, 2015/10/07 18:45:58]

This interface is the one thing I’m not sure about. Users of this interface
probably won’t normally mean to specify create=false.

I was thinking of breaking this into Initialize() and
InitializeWithoutCreating() instead. Any preference?

[scottmg, 2015/10/07 19:16:30]

I agree, I think a separate interface method for normal usage would be clearer. 

Alternatively, an enum class : bool so that it's more obvious at the callsite
that it might be a bad idea to say `false`.

 
   //! \brief Returns the Settings object for this database.
   //!