crashpad_database_util: Don’t create a database unless explicitly asked

tools/crashpad_database_util.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 28 matching lines @@
 #include "util/misc/uuid.h"
 
 namespace crashpad {
 namespace {
 
 void Usage(const base::FilePath& me) {
   fprintf(stderr,
 "Usage: %" PRFilePath " [OPTION]... PID\n"
 "Operate on Crashpad crash report databases.\n"
 "\n"
+"      --create                    allow database at PATH to be created\n"
 "  -d, --database=PATH             operate on the crash report database at PATH\n"
 "      --show-client-id            show the client ID\n"
 "      --show-uploads-enabled      show whether uploads are enabled\n"
 "      --show-last-upload-attempt-time\n"
 "                                  show the last-upload-attempt time\n"
 "      --show-pending-reports      show reports eligible for upload\n"
 "      --show-completed-reports    show reports not eligible for upload\n"
 "      --show-all-report-info      with --show-*-reports, show more information\n"
 "      --show-report=UUID          show report stored under UUID\n"
 "      --set-uploads-enabled=BOOL  enable or disable uploads\n"
 "      --set-last-upload-attempt-time=TIME\n"
 "                                  set the last-upload-attempt time to TIME\n"
 "      --new-report=PATH           submit a new report at PATH, or - for stdin\n"
 "      --utc                       show and set UTC times instead of local\n"
 "      --help                      display this help and exit\n"
 "      --version                   output version information and exit\n",
           me.value().c_str());
   ToolSupport::UsageTail(me);
 }
 
 struct Options {
   std::vector<UUID> show_reports;
   std::vector<base::FilePath> new_report_paths;
   const char* database;
   const char* set_last_upload_attempt_time_string;
   time_t set_last_upload_attempt_time;
+  bool create;
   bool show_client_id;
   bool show_uploads_enabled;
   bool show_last_upload_attempt_time;
   bool show_pending_reports;
   bool show_completed_reports;
   bool show_all_report_info;
   bool set_uploads_enabled;
   bool has_set_uploads_enabled;
   bool utc;
 };
@@ skipping 161 matching lines @@
   const base::FilePath argv0(
       ToolSupport::CommandLineArgumentToFilePathStringType(argv[0]));
   const base::FilePath me(argv0.BaseName());
 
   enum OptionFlags {
     // “Short” (single-character) options.
     kOptionDatabase = 'd',
 
     // Long options without short equivalents.
     kOptionLastChar = 255,
+    kOptionCreate,
     kOptionShowClientID,
     kOptionShowUploadsEnabled,
     kOptionShowLastUploadAttemptTime,
     kOptionShowPendingReports,
     kOptionShowCompletedReports,
     kOptionShowAllReportInfo,
     kOptionShowReport,
     kOptionSetUploadsEnabled,
     kOptionSetLastUploadAttemptTime,
     kOptionNewReport,
     kOptionUTC,
 
     // Standard options.
     kOptionHelp = -2,
     kOptionVersion = -3,
   };
 
   const option long_options[] = {
+      {"create", no_argument, nullptr, kOptionCreate},
       {"database", required_argument, nullptr, kOptionDatabase},
       {"show-client-id", no_argument, nullptr, kOptionShowClientID},
       {"show-uploads-enabled", no_argument, nullptr, kOptionShowUploadsEnabled},
       {"show-last-upload-attempt-time",
        no_argument,
        nullptr,
        kOptionShowLastUploadAttemptTime},
       {"show-pending-reports", no_argument, nullptr, kOptionShowPendingReports},
       {"show-completed-reports",
        no_argument,
@@ skipping 14 matching lines @@
       {"help", no_argument, nullptr, kOptionHelp},
       {"version", no_argument, nullptr, kOptionVersion},
       {nullptr, 0, nullptr, 0},
   };
 
   Options options = {};
 
   int opt;
   while ((opt = getopt_long(argc, argv, "d:", long_options, nullptr)) != -1) {
     switch (opt) {
+      case kOptionCreate: {
+        options.create = true;
+        break;
+      }
       case kOptionDatabase: {
         options.database = optarg;
         break;
       }
       case kOptionShowClientID: {
         options.show_client_id = true;
         break;
       }
       case kOptionShowUploadsEnabled: {
         options.show_uploads_enabled = true;
@@ skipping 85 matching lines @@
                                  options.show_uploads_enabled +
                                  options.show_last_upload_attempt_time +
                                  options.show_pending_reports +
                                  options.show_completed_reports +
                                  options.show_reports.size() +
                                  options.new_report_paths.size();
   const size_t set_operations =
       options.has_set_uploads_enabled +
       (options.set_last_upload_attempt_time_string != nullptr);
 
-  if (show_operations + set_operations == 0) {
+  if ((options.create ? 1 : 0) + show_operations + set_operations == 0) {
     ToolSupport::UsageHint(me, "nothing to do");
     return EXIT_FAILURE;
   }
 
-  scoped_ptr<CrashReportDatabase> database(CrashReportDatabase::Initialize(
-      base::FilePath(ToolSupport::CommandLineArgumentToFilePathStringType(
-          options.database))));
+  scoped_ptr<CrashReportDatabase> database;
+  base::FilePath database_path = base::FilePath(
+      ToolSupport::CommandLineArgumentToFilePathStringType(options.database));
+  if (options.create) {
+    database = CrashReportDatabase::Initialize(database_path);
+  } else {
+    database = CrashReportDatabase::InitializeWithoutCreating(database_path);
+  }
   if (!database) {
     return EXIT_FAILURE;
   }
 
   Settings* settings = database->GetSettings();
 
   // Handle the “show” options before the “set” options so that when they’re
   // specified together, the “show” option reflects the initial state.
 
   if (options.show_client_id) {
@@ skipping 161 matching lines @@
 
 #if defined(OS_POSIX)
 int main(int argc, char* argv[]) {
   return crashpad::DatabaseUtilMain(argc, argv);
 }
 #elif defined(OS_WIN)
 int wmain(int argc, wchar_t* argv[]) {
   return crashpad::ToolSupport::Wmain(argc, argv, crashpad::DatabaseUtilMain);
 }
 #endif  // OS_POSIX