Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 1395643004: remove most of the StrongOptions (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -419 lines) Patch
M lib/src/checker/resolver.dart View 4 chunks +10 lines, -56 lines 0 comments Download
M lib/src/checker/rules.dart View 1 2 chunks +7 lines, -7 lines 0 comments Download
M lib/strong_mode.dart View 1 2 chunks +5 lines, -65 lines 0 comments Download
M test/checker/checker_test.dart View 2 chunks +3 lines, -148 lines 0 comments Download
M test/checker/inferred_type_test.dart View 24 chunks +73 lines, -131 lines 0 comments Download
M test/testing.dart View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
I kept the one option used by analyzer_cli
5 years, 2 months ago (2015-10-08 23:27:40 UTC) #2
vsm
lgtm
5 years, 2 months ago (2015-10-09 15:34:52 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-10-09 20:24:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
33e84a7f2a4e142bc265e44e6e2515a379aa6e9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698