Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: components/about_handler/url_request_about_job.cc

Issue 1395643003: Fix two URLRequestJob subclasses that didn't support cancellation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add OWNERS Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Simple implementation of about: protocol handler that treats everything as 5 // Simple implementation of about: protocol handler that treats everything as
6 // about:blank. No other about: features should be available to web content, 6 // about:blank. No other about: features should be available to web content,
7 // so they're not implemented here. 7 // so they're not implemented here.
8 8
9 #include "components/about_handler/url_request_about_job.h" 9 #include "components/about_handler/url_request_about_job.h"
10 10
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 24
25 void URLRequestAboutJob::Start() { 25 void URLRequestAboutJob::Start() {
26 // Start reading asynchronously so that all error reporting and data 26 // Start reading asynchronously so that all error reporting and data
27 // callbacks happen as they would for network requests. 27 // callbacks happen as they would for network requests.
28 base::ThreadTaskRunnerHandle::Get()->PostTask( 28 base::ThreadTaskRunnerHandle::Get()->PostTask(
29 FROM_HERE, 29 FROM_HERE,
30 base::Bind(&URLRequestAboutJob::StartAsync, weak_factory_.GetWeakPtr())); 30 base::Bind(&URLRequestAboutJob::StartAsync, weak_factory_.GetWeakPtr()));
31 } 31 }
32 32
33 void URLRequestAboutJob::Kill() {
34 weak_factory_.InvalidateWeakPtrs();
35 URLRequestJob::Kill();
36 }
37
33 bool URLRequestAboutJob::GetMimeType(std::string* mime_type) const { 38 bool URLRequestAboutJob::GetMimeType(std::string* mime_type) const {
34 *mime_type = "text/html"; 39 *mime_type = "text/html";
35 return true; 40 return true;
36 } 41 }
37 42
38 URLRequestAboutJob::~URLRequestAboutJob() { 43 URLRequestAboutJob::~URLRequestAboutJob() {
39 } 44 }
40 45
41 void URLRequestAboutJob::StartAsync() { 46 void URLRequestAboutJob::StartAsync() {
42 NotifyHeadersComplete(); 47 NotifyHeadersComplete();
43 } 48 }
44 49
45 } // namespace about_handler 50 } // namespace about_handler
OLDNEW
« no previous file with comments | « components/about_handler/url_request_about_job.h ('k') | net/url_request/url_request_error_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698