Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1395613006: Record zero-suggest selections as empty input. (Closed)

Created:
5 years, 2 months ago by Maria
Modified:
5 years, 2 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record zero-suggest selections as empty input. This makes typed length metric in omnibox event more useful -- we can tell zero-suggest entries by empty selected input instead of recording the URL lengths in that case. BUG=529892 Committed: https://crrev.com/51a1b02fded6b82fc2d4e48eba899e761f5f47e4 Cr-Commit-Position: refs/heads/master@{#353948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/omnibox/browser/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Maria
5 years, 2 months ago (2015-10-12 20:49:39 UTC) #2
Mark P
lgtm
5 years, 2 months ago (2015-10-13 21:19:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395613006/1
5 years, 2 months ago (2015-10-14 01:36:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 02:27:01 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:28:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51a1b02fded6b82fc2d4e48eba899e761f5f47e4
Cr-Commit-Position: refs/heads/master@{#353948}

Powered by Google App Engine
This is Rietveld 408576698