Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 13956006: Remove insertRange. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebuild DOM (unrelated CL) and update status files. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 079abf3916fcf097e584ad8dd80f0a591032453a..6ddde507c4ff136d6db8a0b3dae13ef0a6d642cd 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7020,14 +7020,10 @@ class DomMimeTypeArray implements JavaScriptIndexingBehavior, List<DomMimeType>
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [DomMimeType initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<DomMimeType> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -7303,14 +7299,10 @@ class DomPluginArray implements JavaScriptIndexingBehavior, List<DomPlugin> nati
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [DomPlugin initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<DomPlugin> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -7713,14 +7705,10 @@ class DomStringList implements JavaScriptIndexingBehavior, List<String> native "
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [String initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<String> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -7975,11 +7963,7 @@ class _ChildrenElementList extends ListBase<Element> {
_childElements.retainWhere(test);
}
- void removeRange(int start, int rangeLength) {
- throw new UnimplementedError();
- }
-
- void insertRange(int start, int rangeLength, [initialValue = null]) {
+ void removeRange(int start, int end) {
throw new UnimplementedError();
}
@@ -8101,11 +8085,7 @@ class _FrozenElementList extends ListBase {
throw new UnsupportedError('');
}
- void removeRange(int start, int rangeLength) {
- throw new UnsupportedError('');
- }
-
- void insertRange(int start, int rangeLength, [initialValue = null]) {
+ void removeRange(int start, int end) {
throw new UnsupportedError('');
}
@@ -10453,14 +10433,10 @@ class FileList implements JavaScriptIndexingBehavior, List<File> native "*FileLi
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [File initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<File> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -10937,14 +10913,10 @@ class Float32Array extends ArrayBufferView implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [num initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<num> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -11163,14 +11135,10 @@ class Float64Array extends ArrayBufferView implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [num initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<num> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -11876,14 +11844,10 @@ class HtmlAllCollection implements JavaScriptIndexingBehavior, List<Node> native
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Node initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Node> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -12091,14 +12055,10 @@ class HtmlCollection implements JavaScriptIndexingBehavior, List<Node> native "*
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Node initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Node> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -14129,14 +14089,10 @@ class Int16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -14355,14 +14311,10 @@ class Int32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -14581,14 +14533,10 @@ class Int8Array extends ArrayBufferView implements JavaScriptIndexingBehavior, L
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -17017,14 +16965,10 @@ class _ChildNodeListLazy extends ListBase<Node> {
throw new UnsupportedError(
"Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError(
"Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Node initialValue]) {
- throw new UnsupportedError(
- "Cannot insertRange on immutable List.");
- }
Iterable<Node> getRange(int start, int end) {
throw new UnimplementedError("NodeList.getRange");
@@ -17584,14 +17528,10 @@ class NodeList implements JavaScriptIndexingBehavior, List<Node> native "*NodeLi
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Node initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Node> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -19994,14 +19934,10 @@ class SourceBufferList extends EventTarget implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [SourceBuffer initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<SourceBuffer> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -20282,14 +20218,10 @@ class SpeechGrammarList implements JavaScriptIndexingBehavior, List<SpeechGramma
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [SpeechGrammar initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<SpeechGrammar> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -21733,14 +21665,10 @@ class TextTrackCueList implements List<TextTrackCue>, JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [TextTrackCue initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<TextTrackCue> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -21946,14 +21874,10 @@ class TextTrackList extends EventTarget implements JavaScriptIndexingBehavior, L
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [TextTrack initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<TextTrack> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -22385,14 +22309,10 @@ class TouchList implements JavaScriptIndexingBehavior, List<Touch> native "*Touc
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Touch initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Touch> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -22861,14 +22781,10 @@ class Uint16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -23087,14 +23003,10 @@ class Uint32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -23313,14 +23225,10 @@ class Uint8Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -23536,14 +23444,10 @@ class Uint8ClampedArray extends Uint8Array implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [int initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<int> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -25825,14 +25729,10 @@ class _ClientRectList implements JavaScriptIndexingBehavior, List<Rect> native "
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Rect initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Rect> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -26039,14 +25939,10 @@ class _CssRuleList implements JavaScriptIndexingBehavior, List<CssRule> native "
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [CssRule initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<CssRule> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -26244,14 +26140,10 @@ class _CssValueList extends _CSSValue implements JavaScriptIndexingBehavior, Lis
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [_CSSValue initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<_CSSValue> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -26517,14 +26409,10 @@ class _EntryArray implements JavaScriptIndexingBehavior, List<Entry> native "*En
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Entry initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Entry> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -26722,14 +26610,10 @@ class _EntryArraySync implements JavaScriptIndexingBehavior, List<_EntrySync> na
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [_EntrySync initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<_EntrySync> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -26970,14 +26854,10 @@ class _GamepadList implements JavaScriptIndexingBehavior, List<Gamepad> native "
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Gamepad initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Gamepad> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -27238,14 +27118,10 @@ class _NamedNodeMap implements JavaScriptIndexingBehavior, List<Node> native "*N
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [Node initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<Node> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -27514,14 +27390,10 @@ class _SpeechInputResultList implements JavaScriptIndexingBehavior, List<SpeechI
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [SpeechInputResult initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<SpeechInputResult> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -27719,14 +27591,10 @@ class _SpeechRecognitionResultList implements JavaScriptIndexingBehavior, List<S
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [SpeechRecognitionResult initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<SpeechRecognitionResult> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -27924,14 +27792,10 @@ class _StyleSheetList implements JavaScriptIndexingBehavior, List<StyleSheet> na
throw new UnsupportedError("Cannot setRange on immutable List.");
}
- void removeRange(int start, int rangeLength) {
+ void removeRange(int start, int end) {
throw new UnsupportedError("Cannot removeRange on immutable List.");
}
- void insertRange(int start, int rangeLength, [StyleSheet initialValue]) {
- throw new UnsupportedError("Cannot insertRange on immutable List.");
- }
-
Iterable<StyleSheet> getRange(int start, int end) =>
IterableMixinWorkaround.getRangeList(this, start, end);
@@ -28758,6 +28622,12 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
_target.$dom_removeEventListener(_eventType, _onData, _useCapture);
}
}
+
+ Future asFuture([var futureValue]) {
+ // We just need a future that will never succeed or fail.
+ Completer completer = new Completer();
+ return completer.future;
+ }
}
@@ -31061,11 +30931,7 @@ class _WrappedList<E> implements List<E> {
_list.setRange(start, end, iterable, skipCount);
}
- void removeRange(int start, int length) { _list.removeRange(start, length); }
-
- void insertRange(int start, int length, [E fill]) {
- _list.insertRange(start, length, fill);
- }
+ void removeRange(int start, int end) { _list.removeRange(start, end); }
Map<int, E> asMap() => _list.asMap();
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698