Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: build/config/nacl/BUILD.gn

Issue 1395573003: Build nacl_helper_nonsfi with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup the compiler configuration Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/nacl/BUILD.gn
diff --git a/build/config/nacl/BUILD.gn b/build/config/nacl/BUILD.gn
index 541bb0c475d19e9ec40802a108dc2f0cf5209c3b..1c5690570b8bbb082b170d8162b3f243e0632f44 100644
--- a/build/config/nacl/BUILD.gn
+++ b/build/config/nacl/BUILD.gn
@@ -38,6 +38,7 @@ source_set("nacl_base") {
config("compiler") {
configs = []
cflags = []
+ ldflags = []
if (is_clang && current_cpu != "pnacl") {
# -no-integrated-as is the default in nacl-clang for historical
@@ -48,6 +49,14 @@ config("compiler") {
# everywhere for consistency (and possibly quicker builds).
cflags += [ "-integrated-as" ]
}
+ if (is_nacl_nonsfi) {
+ cflags += [
+ "--pnacl-allow-native",
Mark Seaborn 2015/10/22 21:48:30 Is there a reason that some of these flags are in
Petr Hosek 2015/10/23 03:01:15 Yes, I tried to follow the existing conventions.
+ "--pnacl-allow-translate",
+ ]
+ ldflags += [ "--pnacl-allow-native" ]
+ include_dirs = [ "//native_client/src/public/linux_syscalls" ]
+ }
asmflags = cflags
}

Powered by Google App Engine
This is Rietveld 408576698