Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4405)

Unified Diff: chrome/test/BUILD.gn

Issue 1395573003: Build nacl_helper_nonsfi with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | components/nacl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index c3f1782ae5bcd7e79d5d83094d3b73f0863bb8d9..804b7559e97783ca0d2319233eea14b44830e54c 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -427,9 +427,9 @@ if (!is_android) {
]
if (enable_nacl) {
- deps += [
+ data_deps += [
"//components/nacl:nacl_helper",
- # '../components/nacl_nonsfi.gyp:nacl_helper_nonsfi', TODO(GYP)
+ "//components/nacl:helper_nonsfi",
]
}
@@ -984,7 +984,7 @@ if (!is_android) {
if (is_linux) {
data_deps += [
"//components/nacl:nacl_helper",
- # "//components/nacl_nonsfi.gyp:nacl_helper_nonsfi", # TODO(GYP) bug 512912.
+ "//components/nacl:helper_nonsfi",
]
}
}
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | components/nacl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698