Chromium Code Reviews| Index: base/BUILD.gn |
| diff --git a/base/BUILD.gn b/base/BUILD.gn |
| index 0d53aaabe60129123b9244adb74acd49fc2db913..fb80add425b57926f32417dd84ca329ae8782d87 100644 |
| --- a/base/BUILD.gn |
| +++ b/base/BUILD.gn |
| @@ -3,6 +3,7 @@ |
| # found in the LICENSE file. |
| import("//build/config/compiler/compiler.gni") |
| +import("//build/config/nacl/config.gni") |
| import("//build/config/ui.gni") |
| import("//testing/test.gni") |
| @@ -26,6 +27,16 @@ if (is_win) { |
| } |
| } |
| +if (is_nacl_nonsfi) { |
| + # Must be in a config because of how GN orders flags (otherwise -Wall will |
| + # appear after this, and turn it back on). |
| + config("clang_warnings") { |
|
brettw
2015/10/25 08:45:33
You just copy-and-pasted the old config name :)
T
Petr Hosek
2015/10/25 22:50:48
Yes and no, I kept the name because it's in fact a
|
| + # file_util_posix.cc contains a function which is not |
| + # being used by nacl_helper_nonsfi. |
| + cflags = [ "-Wno-unused-function" ] |
| + } |
| +} |
| + |
| source_set("base_paths") { |
| sources = [ |
| "base_paths.cc", |
| @@ -735,21 +746,34 @@ component("base") { |
| "cpu.cc", |
| "files/file_enumerator_posix.cc", |
| "files/file_proxy.cc", |
| - "files/file_util.cc", |
| - "files/file_util_posix.cc", |
| "files/file_util_proxy.cc", |
| "files/important_file_writer.cc", |
| "files/important_file_writer.h", |
| "files/scoped_temp_dir.cc", |
| - "message_loop/message_pump_libevent.cc", |
| "native_library_posix.cc", |
| "path_service.cc", |
| - "rand_util_posix.cc", |
| "scoped_native_library.cc", |
| "sync_socket_posix.cc", |
| "sys_info.cc", |
| "sys_info_posix.cc", |
| ] |
| + |
| + if (is_nacl_nonsfi) { |
| + set_sources_assignment_filter([]) |
| + sources += [ "posix/unix_domain_socket_linux.cc" ] |
| + set_sources_assignment_filter(sources_assignment_filter) |
| + sources -= [ "rand_util_nacl.cc" ] |
| + configs += [ ":clang_warnings" ] |
| + } else { |
| + sources -= [ |
| + "files/file_util.cc", |
| + "files/file_util.h", |
| + "files/file_util_posix.cc", |
| + "message_loop/message_pump_libevent.cc", |
| + "message_loop/message_pump_libevent.h", |
| + "rand_util_posix.cc", |
| + ] |
| + } |
| } else { |
| # Remove NaCl stuff. |
| sources -= [ |
| @@ -809,7 +833,7 @@ component("base") { |
| "setupapi.lib", |
| ] |
| all_dependent_configs = [ ":base_win_linker_flags" ] |
| - } else if (!is_nacl) { |
| + } else if (!is_nacl || is_nacl_nonsfi) { |
| # Non-Windows. |
| deps += [ "//third_party/libevent" ] |
| } |