Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3206)

Unified Diff: chrome/test/BUILD.gn

Issue 1395573003: Build nacl_helper_nonsfi with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 218f1d46f9460c4d5e6d76f1acb4addce2985374..027042459c483faa666d1e02b8ef15cf1ab3f799 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -436,11 +436,10 @@ if (!is_android) {
]
if (enable_nacl) {
- deps += [
+ data_deps += [
"//native_client/src/trusted/service_runtime/linux:munge_nacl_helper_bootstrap",
"//components/nacl:nacl_helper",
-
- # '../components/nacl_nonsfi.gyp:nacl_helper_nonsfi', TODO(GYP)
+ "//components/nacl:nacl_helper_nonsfi(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
]
}
@@ -998,8 +997,7 @@ if (!is_android) {
data_deps += [
"//native_client/src/trusted/service_runtime/linux:munge_nacl_helper_bootstrap",
"//components/nacl:nacl_helper",
-
- # "//components/nacl_nonsfi.gyp:nacl_helper_nonsfi", # TODO(GYP) bug 512912.
+ "//components/nacl:nacl_helper_nonsfi(//build/toolchain/nacl:newlib_pnacl_nonsfi)",
]
}
}

Powered by Google App Engine
This is Rietveld 408576698