Build nacl_helper_nonsfi with GN

ipc/BUILD.gn

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/nacl/config.gni")
 import("//testing/test.gni")
 
 component("ipc") {
   sources = [
     "attachment_broker.cc",
     "attachment_broker.h",
     "attachment_broker_messages.h",
     "attachment_broker_privileged.cc",
     "attachment_broker_privileged.h",
     "attachment_broker_privileged_mac.cc",
@@ skipping 95 matching lines @@
     sources -= [
       "ipc_channel_nacl.cc",
       "ipc_channel_nacl.h",
     ]
   }
 
   if (is_win || is_ios) {
     sources -= [ "unix_domain_socket_util.cc" ]
   }
 
+  if (is_nacl_nonsfi) {
+    sources -= [
+      "ipc_channel_nacl.cc",
+      "ipc_channel_nacl.h",
+    ]
+    sources += [

[Mark Seaborn, 2015/10/22 21:48:30]

This mix of adding and removing sources is a bit confusing.

How about merging this with the "if (is_nacl)" block above?

[Petr Hosek, 2015/10/23 03:01:15]

Done.

+      "ipc_channel.cc",
+      "ipc_channel_posix.cc",
+    ]
+  }
+
   defines = [ "IPC_IMPLEMENTATION" ]
 
   deps = [
     "//base",
 
     # TODO(viettrungluu): Needed for base/lazy_instance.h, which is suspect.
     "//base/third_party/dynamic_annotations",
   ]
 
   if (is_win || is_mac) {
@@ skipping 108 matching lines @@
     "test_util_mac.cc",
     "test_util_mac.h",
   ]
   deps = [
     ":ipc",
     "//base",
     "//base/test:test_support",
     "//testing/gtest",
   ]
 }