Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1395573002: Improved AS benchmarking metrics. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
keertip
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improved AS benchmarking metrics. Notably: * adds support for multiple metrics via the `--metric` flag (e.g., `--metric outline,navigation,highlighting`). * captures timings in a list in case there are multiple results (e.g., outline before and after resolution). R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/37d4be8f61030b9221eaec411a0a6b9f68055c60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -83 lines) Patch
M pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart View 2 chunks +65 lines, -83 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-07 17:19:57 UTC) #2
keertip
lgtm
5 years, 2 months ago (2015-10-07 17:33:12 UTC) #3
pquitslund
5 years, 2 months ago (2015-10-07 20:09:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37d4be8f61030b9221eaec411a0a6b9f68055c60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698