Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1395553003: Remove stun server in webrtc peerconnection.js (Closed)

Created:
5 years, 2 months ago by guoweis_left_chromium
Modified:
5 years, 2 months ago
Reviewers:
phoglund_chromium, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stun server in webrtc peerconnection.js Specifying the stun server which can't be accessed in the test environment disallows WebRTC to generate loopback candidates. The current logic for generating loopback candidates is that if the permission is denied, the RtcConfiguration has to be null or undefined. This prevents the turning on of IP Permission check as in https://codereview.chromium.org/1380323005/ BUG=538815 Committed: https://crrev.com/da45e6c11a011a33795fa899133667aa8642caca Cr-Commit-Position: refs/heads/master@{#353113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/test/data/webrtc/peerconnection.js View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
guoweis_left_chromium
5 years, 2 months ago (2015-10-07 16:56:34 UTC) #2
phoglund_chromium
lgtm
5 years, 2 months ago (2015-10-08 07:41:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395553003/1
5 years, 2 months ago (2015-10-08 16:56:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395553003/1
5 years, 2 months ago (2015-10-08 17:17:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395553003/1
5 years, 2 months ago (2015-10-08 17:21:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 18:51:50 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 18:53:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da45e6c11a011a33795fa899133667aa8642caca
Cr-Commit-Position: refs/heads/master@{#353113}

Powered by Google App Engine
This is Rietveld 408576698