third_party/WebKit/LayoutTests/fast/media/mq-display-mode.html - Issue 1395543005: matchMedia('(display-mode: <notValid>)').matches should not evaluate true

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/media/mq-display-mode.html

Issue 1395543005: matchMedia('(display-mode: <notValid>)').matches should not evaluate true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/media/mq-display-mode-expected.txt » ('j') | third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Test the Manifest media query "display-mode" features.</title>	3 <title>Test the Manifest media query "display-mode" features.</title>

4 <style type="text/css">	4 <style type="text/css">

5	5

6 </style>	6 </style>

7 <script type="text/javascript" charset="utf-8">	7 <script type="text/javascript" charset="utf-8">

8 if (window.testRunner)	8 if (window.testRunner)

9 testRunner.dumpAsText();	9 testRunner.dumpAsText();

10	10

11 function log(m) {	11 function log(m) {

12 document.getElementById('results').innerHTML += m + '<br>';	12 document.getElementById('results').innerHTML += m + '<br>';

13 }	13 }

14	14

15 function testQueries()	15 function testQueries()

16 {	16 {

17 var queries = [	17 var queries = [

18 "(display-mode)",	18 "(display-mode)",

19 "(display-mode: browser)",	19 "(display-mode: browser)",

20 "(display-mode: minimal-ui)",	20 "(display-mode: minimal-ui)",

21 "(display-mode: standalone)",	21 "(display-mode: standalone)",

22 "(display-mode: fullscreen)",	22 "(display-mode: fullscreen)",

	23 "(display-mode: fine)",
	Mikhail 2015/10/13 14:01:16 comment here, like "// Unexpected values." comment here, like "// Unexpected values."
	24 "(display-mode: 1)",

	25 "(display-mode: 3%)",

23 ];	26 ];

24 for (var index=0; index < queries.length; index++) {	27 for (var index=0; index < queries.length; index++) {

25 log("Query "" + queries[index] + "&quot: " +	28 log("Query "" + queries[index] + "&quot: " +

26 window.matchMedia(queries[index]).matches);	29 window.matchMedia(queries[index]).matches);

27 }	30 }

28 }	31 }

29	32

30 function runTests()	33 function runTests()

31 {	34 {

32 if (!window.internals)	35 if (!window.internals)

(...skipping 18 matching lines...) Expand all Loading...
51	54

52 </script>	55 </script>

53 </head>	56 </head>

54 <body onload="runTests()">	57 <body onload="runTests()">

55 <p>Test the <a href="http://w3c.github.io/manifest/#the-display-mode-media-f eature">(display-mode: ...)</a> media features.	58 <p>Test the <a href="http://w3c.github.io/manifest/#the-display-mode-media-f eature">(display-mode: ...)</a> media features.

56	59

57 <div id="results">	60 <div id="results">

58 </div>	61 </div>

59 </body>	62 </body>

60 </html>	63 </html>

OLD	NEW