Issue 1395543003: VM: Fix FP math discrepancies by adding -mfpmath=sse to 32-bit simulator and cross host builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395543003: VM: Fix FP math discrepancies by adding -mfpmath=sse to 32-bit simulator and cross host builds. (Closed)

Created:
5 years, 2 months ago by Florian Schneider

Modified:
5 years, 2 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix FP math discrepancies by adding -mfpmath=sse to 32-bit simulator and cross host builds. BUG=dartbug.com/24517 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/9f54259d57d84f096554a0c4ae192bd2149e811d

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
	A	tests/language/vm/regress_24517_test.dart	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
	M	tools/gyp/configurations_make.gypi	View		5 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 5 (1 generated)

zra

lgtm The gcc docs for -msse2 seem to imply that when it is present, -mfpmath=sse ...

5 years, 2 months ago (2015-10-07 15:00:58 UTC) #3

Florian Schneider

On 2015/10/07 15:00:58, zra wrote: > lgtm > > The gcc docs for -msse2 seem ...

5 years, 2 months ago (2015-10-07 15:37:54 UTC) #4

Florian Schneider

5 years, 2 months ago (2015-10-08 15:16:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9f54259d57d84f096554a0c4ae192bd2149e811d (presubmit successful).