Issue 1395543002: Add non-logging OpenFileForWrite() and OpenFileForReadAndWrite()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395543002: Add non-logging OpenFileForWrite() and OpenFileForReadAndWrite() (Closed)

Created:
5 years, 2 months ago by Mark Mentovai

Modified:
5 years, 2 months ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Add non-logging OpenFileForWrite() and OpenFileForReadAndWrite() BUG=crashpad:63 TEST=crashpad_util_test FileIO.*OpenFileFor* R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/78592537bcc3dfa720227344b7281be553533322

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -77 lines)			Patch
M	util/file/file_io.h	View	3 chunks	+48 lines, -12 lines	0 comments	Download
M	util/file/file_io_posix.cc	View	4 chunks	+32 lines, -12 lines	0 comments	Download
M	util/file/file_io_test.cc	View	4 chunks	+46 lines, -29 lines	0 comments	Download
M	util/file/file_io_win.cc	View	4 chunks	+46 lines, -24 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 2 months ago (2015-10-07 15:40:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
78592537bcc3dfa720227344b7281be553533322 (presubmit successful).