Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1395533005: Use <type_traits> in the C++ bindings library wherever possible. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use <type_traits> in the C++ bindings library wherever possible. (Remove our imitation versions in lib/template_util.h.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e261f03290d1cbba3346e6a8b3a0b46eabbbb8cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -109 lines) Patch
M mojo/public/cpp/bindings/callback.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 4 chunks +10 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_internal.h View 5 chunks +11 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 4 chunks +10 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/template_util.h View 2 chunks +7 lines, -80 lines 0 comments Download
M mojo/public/cpp/bindings/map.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-13 17:54:58 UTC) #1
jamesr
lgtm
5 years, 2 months ago (2015-10-13 18:15:20 UTC) #2
viettrungluu
5 years, 2 months ago (2015-10-13 18:16:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e261f03290d1cbba3346e6a8b3a0b46eabbbb8cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698