Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395533002: Add DrawShipSim sample. (Closed)

Created:
5 years, 2 months ago by jvanverth1
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add DrawShipSim sample. Adds a version of the DrawShip sample that uses drawRect with a bitmap. For testing batching. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9011bcf36e7ef9d6e7dab7f6e04c47c18972fbeb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M samplecode/SampleShip.cpp View 4 chunks +32 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
5 years, 2 months ago (2015-10-07 15:53:27 UTC) #2
bsalomon
lgtm
5 years, 2 months ago (2015-10-07 17:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395533002/1
5 years, 2 months ago (2015-10-07 17:36:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9011bcf36e7ef9d6e7dab7f6e04c47c18972fbeb
5 years, 2 months ago (2015-10-07 17:43:41 UTC) #6
robertphillips
5 years, 2 months ago (2015-10-07 18:07:00 UTC) #7
Message was sent while issue was closed. 
post mortem

https://codereview.chromium.org/1395533002/diff/1/samplecode/SampleShip.cpp
File samplecode/SampleShip.cpp (right):

https://codereview.chromium.org/1395533002/diff/1/samplecode/SampleShip.cpp#n...
samplecode/SampleShip.cpp:23: typedef void (*DrawAtlasProc)(SkCanvas*, SkImage*,
const SkRSXform[], const SkRect[],
tab over ?

https://codereview.chromium.org/1395533002/diff/1/samplecode/SampleShip.cpp#n...
samplecode/SampleShip.cpp:32: static void draw_atlas_sim(SkCanvas* canvas,
SkImage* atlas, const SkRSXform xform[],
\n ?

Powered by Google App Engine
This is Rietveld 408576698