Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 139553004: Remove extra slash from proxy-preconnect path. (Closed)

Created:
6 years, 11 months ago by marq (ping after 24h)
Modified:
6 years, 11 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@auth401
Visibility:
Public.

Description

Remove extra slash from proxy-preconnect path. BUG=333919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245182

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/net/spdyproxy/proxy_advisor.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marq (ping after 24h)
6 years, 11 months ago (2014-01-15 19:04:20 UTC) #1
bengr
lgtm https://codereview.chromium.org/139553004/diff/1/chrome/browser/net/spdyproxy/proxy_advisor.cc File chrome/browser/net/spdyproxy/proxy_advisor.cc (right): https://codereview.chromium.org/139553004/diff/1/chrome/browser/net/spdyproxy/proxy_advisor.cc#newcode121 chrome/browser/net/spdyproxy/proxy_advisor.cc:121: endpoint += "preconnect"; nit: std::string endpoint = DataReductionProxySettings::GetDataReductionProxyOrigin() ...
6 years, 11 months ago (2014-01-15 20:57:12 UTC) #2
marq (ping after 24h)
Thanks for the review. https://codereview.chromium.org/139553004/diff/1/chrome/browser/net/spdyproxy/proxy_advisor.cc File chrome/browser/net/spdyproxy/proxy_advisor.cc (right): https://codereview.chromium.org/139553004/diff/1/chrome/browser/net/spdyproxy/proxy_advisor.cc#newcode121 chrome/browser/net/spdyproxy/proxy_advisor.cc:121: endpoint += "preconnect"; On 2014/01/15 ...
6 years, 11 months ago (2014-01-15 21:51:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marq@chromium.org/139553004/90001
6 years, 11 months ago (2014-01-15 22:01:34 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:57:15 UTC) #5
Message was sent while issue was closed.
Change committed as 245182

Powered by Google App Engine
This is Rietveld 408576698