Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 139553003: cc: Fix thread race on writing commit_waits_for_activation_. (Closed)

Created:
6 years, 11 months ago by danakj
Modified:
6 years, 11 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, Alexander Potapenko, piman
Visibility:
Public.

Description

cc: Fix thread race on writing commit_waits_for_activation_. Under non-impl-side painting, the thread proxy ends up releasing the main thread then setting commit_waits_for_activation_ to false, which is the wrong way around. This puts the order right. R=enne BUG=334611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M cc/trees/thread_proxy.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
6 years, 11 months ago (2014-01-15 16:47:41 UTC) #1
enne (OOO)
lgtm One random thought which you can take or leave--what about wrapping that variable (and ...
6 years, 11 months ago (2014-01-15 18:01:06 UTC) #2
danakj
On 2014/01/15 18:01:06, enne wrote: > lgtm > > One random thought which you can ...
6 years, 11 months ago (2014-01-15 18:10:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/139553003/1
6 years, 11 months ago (2014-01-15 18:30:03 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:44:57 UTC) #5
Message was sent while issue was closed.
Change committed as 245269

Powered by Google App Engine
This is Rietveld 408576698