Issue 139553002: Revert of skpmaker: make the SKP slightly more interesting (add a border)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139553002: Revert of skpmaker: make the SKP slightly more interesting (add a border) (Closed)

Created:
6 years, 11 months ago by epoger

Modified:
6 years, 11 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of skpmaker: make the SKP slightly more interesting (add a border) (https://codereview.chromium.org/137993008/) Reason for revert: broke http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/2837 Original issue's description: > skpmaker: make the SKP slightly more interesting (add a border) > > This will help with render_pictures self-testing > BUG=skia:1942 > > Committed: http://code.google.com/p/skia/source/detail?r=13086 TBR=rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1942 Committed: http://code.google.com/p/skia/source/detail?r=13087

Created: 6 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	tools/skpmaker.cpp	View		2 chunks	+3 lines, -8 lines	0 comments	Download
	M	tools/tests/render_pictures_test.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

epoger

Created Revert of skpmaker: make the SKP slightly more interesting (add a border)

6 years, 11 months ago (2014-01-15 16:04:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/139553002/1

6 years, 11 months ago (2014-01-15 16:04:41 UTC) #2

Message was sent while issue was closed.

Change committed as 13087