Issue 1395493007: Introduce CPDF_Document::FromFPDFDocument().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395493007: Introduce CPDF_Document::FromFPDFDocument(). (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Introduce CPDF_Document::FromFPDFDocument(). This will be used to abstract one major difference between master and XFA, namely that the CPDF_Document is not a direct cast in XFA. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bb51c4fb6bc6095984c303c95e5336f83e66bc67

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -99 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/fpdf_dataavail.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdf_ext.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdfdoc.cpp	View	10 chunks	+37 lines, -30 lines	0 comments	Download
M	fpdfsdk/src/fpdfeditimg.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/fpdfeditpage.cpp	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/fpdfformfill.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdfppo.cpp	View	2 chunks	+14 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/fpdfsave.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	10 chunks	+40 lines, -39 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, for review. This technique should eliminate a lot of repeated diffs.

5 years, 2 months ago (2015-10-14 22:37:12 UTC) #2

Tom Sepez

5 years, 2 months ago (2015-10-14 23:34:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bb51c4fb6bc6095984c303c95e5336f83e66bc67 (presubmit successful).