chrome/browser/ui/cocoa/login_prompt_cocoa.mm - Issue 1395473003: Follow-up clean-up in LoginHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

Issue 1395473003: Follow-up clean-up in LoginHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

index daa4f9b3297bfa6c2ceed89ee74f47dd4dbcd8b6..4ba6292430185bc2a1123091a1e953957cbe772b 100644

--- a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

+++ b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

@@ -52,8 +52,8 @@ class LoginHandlerMac : public LoginHandler,

void OnLoginModelDestroying() override {}

// LoginHandler:

- void BuildView(const base::string16& explanation,

- LoginModelData* login_model_data) override {

+ void BuildViewImpl(const base::string16& explanation,

+ LoginModelData* login_model_data) override {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

sheet_controller_.reset(