Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: src/compiler/js-inlining.cc

Issue 1395453002: [turbofan] Don't try to inline non-inlineable functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-crbug-540593.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining.cc
diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc
index 0b7c78979c8869fffe25f801bda4df5b5e0b9dac..5cbb9604d6adfacc7741d1a2e811ecbbdd8264d8 100644
--- a/src/compiler/js-inlining.cc
+++ b/src/compiler/js-inlining.cc
@@ -254,6 +254,14 @@ Reduction JSInliner::Reduce(Node* node) {
return NoChange();
}
+ if (!function->shared()->IsInlineable()) {
+ // Function must be inlineable.
+ TRACE("Not inlining %s into %s because callee is not inlineable\n",
+ function->shared()->DebugName()->ToCString().get(),
+ info_->shared_info()->DebugName()->ToCString().get());
+ return NoChange();
+ }
+
if (function->shared()->HasDebugInfo()) {
// Function contains break points.
TRACE("Not inlining %s into %s because callee may contain break points\n",
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-crbug-540593.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698