Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 139543006: net: Disable HostResolverImplTest for TSAN (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
szym, oshima
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Visibility:
Public.

Description

net: Disable HostResolverImplTest for TSAN TBR=szym@chromium.org BUG=334837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M net/dns/host_resolver_impl_unittest.cc View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/139543006/1
6 years, 11 months ago (2014-01-16 09:49:54 UTC) #1
hashimoto
6 years, 11 months ago (2014-01-16 09:50:29 UTC) #2
szym
Any plan to address this problem in general? (e.g., join WorkerPool or mutex CommandLine)
6 years, 11 months ago (2014-01-16 10:01:51 UTC) #3
hashimoto
On 2014/01/16 10:01:51, szym wrote: > Any plan to address this problem in general? (e.g., ...
6 years, 11 months ago (2014-01-16 10:05:50 UTC) #4
szym
lgtm
6 years, 11 months ago (2014-01-16 10:07:12 UTC) #5
commit-bot: I haz the power
Change committed as 245268
6 years, 11 months ago (2014-01-16 18:43:39 UTC) #6
oshima
Correct way to handle it is to exclude these tests in tools/valgrind/gtest_exclude/net_tests.gtest-*.txt
6 years, 11 months ago (2014-01-16 23:14:01 UTC) #7
hashimoto
6 years, 11 months ago (2014-01-17 10:17:45 UTC) #8
Message was sent while issue was closed.
On 2014/01/16 23:14:01, oshima wrote:
> Correct way to handle it is to exclude these tests in
> 
> tools/valgrind/gtest_exclude/net_tests.gtest-*.txt

Does this work for the failing TSan v2 bot
(http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28T...
From what I can see from the bot's stdio output, even the tests listed in
net_unittests.gtest-tsan.txt are running on the bot.

Powered by Google App Engine
This is Rietveld 408576698