Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.js

Issue 139543005: Reject filesystem root entries as args for chrome.fileSystem functions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.js
diff --git a/chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/test.js b/chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.js
similarity index 61%
copy from chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/test.js
copy to chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.js
index 08ff1e531163b577bc30f01a3fdabe32f8476592..205bf9c8f6242ebcbd9c6b55d516e2764b17143b 100644
--- a/chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/test.js
+++ b/chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.js
@@ -6,11 +6,10 @@ chrome.test.runTests([
function getWritableEntry() {
chrome.fileSystem.chooseEntry(chrome.test.callbackPass(function(entry) {
chrome.test.assertEq('writable.txt', entry.name);
- // Test that we can get the display path of the file.
- chrome.fileSystem.getWritableEntry(entry, chrome.test.callbackPass(
- function(writable) {
- checkEntry(writable, 'writable.txt', false, true);
- }));
+ // Test that we cannot get a writable entry for the root entry.
+ chrome.fileSystem.getWritableEntry(
+ entry.filesystem.root, chrome.test.callbackFail(
+ 'Invalid parameters'));
}));
}
]);
« no previous file with comments | « chrome/test/data/extensions/api_test/file_system/get_writable_root_entry/test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698