Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: net/quic/quic_connection.cc

Issue 1395423009: relnote: add test cases to catch failure on uninitialized self_address_ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_comment_104108540
Patch Set: Minor cleanup Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index c8a5de17389c2c776e54f465eaace43b34ede590..b9c9312e2f04d70b734f91c76a75760a5ce9c7a1 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1623,7 +1623,9 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
OnWriteError(result.error_code);
DLOG(ERROR) << ENDPOINT << "failed writing " << encrypted->length()
<< " bytes "
- << " from host " << self_address().ToStringWithoutPort()
+ << " from host " << (self_address().address().empty()
ramant (doing other things) 2015/10/15 00:47:55 Hi Ryan, The new test crashes on chromium becaus
+ ? " empty address "
+ : self_address().ToStringWithoutPort())
<< " to address " << peer_address().ToString();
return false;
}
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698