relnote: add test cases to catch failure on uninitialized self_address_

relnote: add test cases to catch failure on uninitialized self_address_
on chromium side, always set the self_address_ when client creates a new
session and connection.

There's a corner case in quic_client, when it tries to write to the
first packet, the write fails. Previously we did not set self_address_
immediately when we created a new quic_connection. This leads to a crash
on chromium side when logging the uninitialized self_address.

Merge internal change: 104130818

R=rch@chromium.org

[ramant (doing other things), 2015-10-15 00:47:55]

https://codereview.chromium.org/1395423009/diff/20001/net/quic/quic_connectio...
File net/quic/quic_connection.cc (right):

https://codereview.chromium.org/1395423009/diff/20001/net/quic/quic_connectio...
net/quic/quic_connection.cc:1626: << " from host " <<
(self_address().address().empty()
Hi Ryan,
  The new test crashes on chromium because self_address().address() is empty
(IPAddressToStringWithPort method crashes). Added a check to
call ToStringWithoutPort only when self_address().address() is not empty.

[Zhongyi Shi, 2015-10-15 02:12:31]

On 2015/10/15 00:47:55, ramant wrote:
>
https://codereview.chromium.org/1395423009/diff/20001/net/quic/quic_connectio...
> File net/quic/quic_connection.cc (right):
> 
>
https://codereview.chromium.org/1395423009/diff/20001/net/quic/quic_connectio...
> net/quic/quic_connection.cc:1626: << " from host " <<
> (self_address().address().empty()
> Hi Ryan,
>   The new test crashes on chromium because self_address().address() is empty
> (IPAddressToStringWithPort method crashes). Added a check to
> call ToStringWithoutPort only when self_address().address() is not empty.

Yeah, this is as expected! The intention for the original google3 cl is to catch
the bug in chromium, though google3 code has internal logic to handle the case
when self_address().address() is unspecified.

[Ryan Hamilton, 2015-10-15 13:44:42]

lgtm. what cherie said is spot on