Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395403002: change more effects to only expose factories (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change more effects to only expose factories BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/f028003cf4429813ae1ac6624efa51ecbb062ed3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M include/effects/SkColorFilterImageFilter.h View 2 chunks +6 lines, -8 lines 0 comments Download
M include/effects/SkModeColorFilter.h View 2 chunks +9 lines, -5 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395403002/1
5 years, 2 months ago (2015-10-12 17:35:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395403002/1
5 years, 2 months ago (2015-10-12 17:37:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f028003cf4429813ae1ac6624efa51ecbb062ed3
5 years, 2 months ago (2015-10-12 18:10:15 UTC) #6
hal.canary
5 years, 2 months ago (2015-10-12 18:50:45 UTC) #7
Message was sent while issue was closed. 
On 2015/10/12 18:10:15, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/f028003cf4429813ae1ac6624efa51ecbb062ed3

Let's simplify this further into a single SkEffects.h
    https://gist.github.com/HalCanary/903fd6757568d1cb9426

Powered by Google App Engine
This is Rietveld 408576698